Michael Ho has posted comments on this change. Change subject: IMPALA-4164: Use inline hints instead of always-inline ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6941/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 163: return Status::OK(); > We have __attribute__((target("avx2"))) on some bloom filter functions alre Good point. They aren't cross-compiled yet but I verified the problem by cross-compiling them. I took your suggestion to set all functions' attributes to be the one derived from 'cpu_attrs_'. Alternately, we may consider stripping the "target-features" attributes of the cross-compiled functions loaded but I don't see an interface defined in llvm::Function. IMHO, it may be clearer to set "target-features" attribute explicitly so we know they are the same for both hand-crafted IR and cross-compiled function. Line 166: LlvmCodeGen::LlvmCodeGen(RuntimeState* state, ObjectPool* pool, > Ah ok, maybe make the log text a bit more human-readable then? I removed them now in the new patch as they would be redundant with cpu_attrs_. -- To view, visit http://gerrit.cloudera.org:8080/6941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d87ae8d222b415587e7320cb9072e4a8d6615ce Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
