Tim Armstrong has posted comments on this change. Change subject: IMPALA-4164: Use inline hints instead of always-inline ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6941/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 163: target_cpu_attr_ = fn->getFnAttribute("target-cpu").getValueAsString(); > Good point. They aren't cross-compiled yet but I verified the problem by cr Yeah that approach seems reasonable unless there's some major cost to duplicating the attributes everywhere (I can't imagine there is). We should test this on a system without some of the CPU features to make sure that it works properly - e.g. if we cross-compiled a function with AVX2 and the system doesn't have that. There are various removeAttributes() APIs but I'm not sure how you construct the arguments to them: http://llvm.org/docs/doxygen/html/classllvm_1_1Function.html#a12df9495b95331ab7ed614624e5268d2 -- To view, visit http://gerrit.cloudera.org:8080/6941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d87ae8d222b415587e7320cb9072e4a8d6615ce Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
