Tim Armstrong has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6950/5/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: Line 315: /// Use __restrict__ so that the compiler knows that it is safe to cache member > And you can't __restrict__ num_values and pool because they actually can al Those shouldn't alias either but there's not much value in caching them because the indirection doesn't seem to have much impact. I'm not sure if it's clearer to apply __restrict__ to all pointers where it would be valid, or to only apply it to those where it provides a performance benefit. What do you think would be clearer? -- To view, visit http://gerrit.cloudera.org:8080/6950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49ec523a65542fdbabd53fbcc4a8901d769e5cd5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
