Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5325: Do not update totalHdfsBytes_/numHdfsFiles_ on Catalogd ......................................................................
Patch Set 3: (1 comment) I wouldn't worry about the supportability aspect. I am working on a patch that will expose table metrics. Of course it will not solve the problem of extracting that information from a heap dump but we will be able to easily monitor live tables. http://gerrit.cloudera.org:8080/#/c/6970/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: PS3, Line 565: numHdfsFiles_ = 0; : totalHdfsBytes_ = 0; Isn't resetPartitions also called for tables stored in the catalog? If so, this violates the invariant that these metrics are -1 for the catalog tables. -- To view, visit http://gerrit.cloudera.org:8080/6970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03cc6f9e9b2c03cafb87029ea0802dfdb2745be1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
