Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5325: Do not update totalHdfsBytes_/numHdfsFiles_ on Catalogd ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Thanks Dimitris, extracting it from the Catalog metrics is much more easier, especially from a live system. Given that I'm fine with this change too. Carrying +1. http://gerrit.cloudera.org:8080/#/c/6970/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: PS3, Line 565: numHdfsFiles_ = 0; : totalHdfsBytes_ = 0; > Isn't resetPartitions also called for tables stored in the catalog? If so, Yes the invariant is violated "during" the load but they are reset to -1 by the end of load() call. Also IMO this invariant needn't be strictly followed given nothing else depends on it. -- To view, visit http://gerrit.cloudera.org:8080/6970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03cc6f9e9b2c03cafb87029ea0802dfdb2745be1 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
