Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6897/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 918: DCHECK(!query_status_.ok()); > Add a TODO that this is weird, since CancelInternal() is called on the succ Done PS2, Line 1094: if (filter_mem_tracker_.get() != nullptr) { : filter_mem_tracker_->UnregisterFromParent(); : } > does that belong here? if not, maybe add TODO to make it clear in the meant Done http://gerrit.cloudera.org:8080/#/c/6897/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: PS2, Line 450: schedule_->Release() > What's that? Maybe it's referring to AdmissionController::ReleaseQuery()? removed that comment, it doesn't make sense (admission control happens prior to creating a coordinator, as it should). -- To view, visit http://gerrit.cloudera.org:8080/6897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I457a6424a0255c137336c4bc01a6e7ed830d18c7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
