Jim Apple has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache ......................................................................
Patch Set 22: (2 comments) http://gerrit.cloudera.org:8080/#/c/6478/22/be/src/runtime/disk-io-mgr-handle-cache.h File be/src/runtime/disk-io-mgr-handle-cache.h: Line 155: uint8_t padding[CACHE_LINE_SIZE]; What happened? The clang-tidy complaints seem to be about other types; doesn't the alignment trick fix it for this one? http://gerrit.cloudera.org:8080/#/c/6478/22/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: Line 199: class DiskIoMgr { This is apparently a type that should be cache-aligned. -- To view, visit http://gerrit.cloudera.org:8080/6478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5ff60971dd653c3b6a0e13928cfa9fc59d078d Gerrit-PatchSet: 22 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
