Dan Hecht has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache ......................................................................
Patch Set 23: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6478/23/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: Line 201: // for its partitions. technically, the alignment decl isn't needed here (struct alignment equals the maximum alignment of fields). but what is needed is the overload new operator. but the comment is fine. -- To view, visit http://gerrit.cloudera.org:8080/6478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5ff60971dd653c3b6a0e13928cfa9fc59d078d Gerrit-PatchSet: 23 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
