Dan Hecht has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates ......................................................................
Patch Set 6: > I updated the patchset to use explain_level EXTENDED for TPC-H and > TPC-DS. This doesn't enable the spill buffer size optimisation for > those test, but you can inspect 'mem-estimate' to get a rough idea > of what the reservation would be with the new code. > > It looks like for the scale factor 1 TPC-H and TPC-DS most joins > would have their reservation scaled down, since mem-estimate <<< 17 > * 2MB buffers. But then the question is does the scaled down reservation impact perf or cause more spilling? -- To view, visit http://gerrit.cloudera.org:8080/6963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57b5b4c528325d478c8a9b834a6bc5dedab54b5b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
