Dan Hecht has posted comments on this change.

Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates
......................................................................


Patch Set 6:

> I think it might be best, if possible, to agree on the planner
 > mechanism first and then tune the policy based on experiments with
 > a more final version of query execution. I could do experiments
 > with the current prototype of query execution but it feels a bit
 > speculative until more pieces are in place.

Yeah, I meant against the new code, not the old. just wanted to think through 
(and verify) the implications, but it doesn't have to block checking it in if 
we all agree this is a good strategy.

-- 
To view, visit http://gerrit.cloudera.org:8080/6963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b5b4c528325d478c8a9b834a6bc5dedab54b5b
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to