anujphadke has posted comments on this change. Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7014/1//COMMIT_MSG Commit Message: > I think this patch needs a test case (I think you already had a query, righ Done. I had tried running similar query to produce a nested loop join. Looks like it is handled correctly there since impala does not crash in that case. I have added the query which crashed impala to the test cases. http://gerrit.cloudera.org:8080/#/c/7014/1/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 498: while (!ReachedLimit()) { > It looks like TransferResourceOwnership() already calls Reset(), so we can Done Line 506: DCHECK(NeedToProcessUnmatchedBuildRows()); > How about we avoid the duplicate ReachedLimit() return path by changing thi Done -- To view, visit http://gerrit.cloudera.org:8080/7014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafd621d33a4e2fac42391504566ffd8dd0e18a67 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
