Tim Armstrong has posted comments on this change. Change subject: IMPALA-5363: Reset probe_batch_ after reaching limit ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7014/2/testdata/workloads/functional-query/queries/QueryTest/joins.test File testdata/workloads/functional-query/queries/QueryTest/joins.test: Line 734: # IMPALA-5363: Reset probe_batch_ after reaching limit. I think this test should be moved to subplans.test. We can't run against nested types in all build configurations so I think this would probably cause the old aggs and joins build to fail. Can you add the equivalent test for NLJ too? I'm not confident we have coverage for that, even though it seems to work. I ran test_nested_types.py with the code in NLJNode commented out and the test passed. -- To view, visit http://gerrit.cloudera.org:8080/7014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafd621d33a4e2fac42391504566ffd8dd0e18a67 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
