Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS ......................................................................
Patch Set 1: (2 comments) questions: - what about insert staging for adls (in coordinator.cc? - what about hdfs-fs-cache, does that need to be extended? http://gerrit.cloudera.org:8080/#/c/7033/1/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 402: // ADLS uses buffer sizes of 4k. Given that, and the above JNI array allocation overhead you mean multiples of 4k? http://gerrit.cloudera.org:8080/#/c/7033/1/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: Line 764: int RemoteADLSDiskId() const { return num_local_disks() + REMOTE_ADLS_DISK_OFFSET; } RemoteAdlsDiskId -- To view, visit http://gerrit.cloudera.org:8080/7033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I067f053fec941e3631610c5cc89a384f257ba906 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
