Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5378: Disk IO manager needs to understand ADLS ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7033/1/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 402: // ADLS uses buffer sizes of 4k. Given that, and the above JNI array allocation overhead > I should have researched this a little better, I used 4k based on some misi but we'd still truncate to the actual length of the column's data pages in the row group (in the parquet context) if that's less than 4mb, no? why do you think that would require more cpu? regarding what value to use: would be good to make this a flag (even if only for the purpose of a test) and run some perf tests to get numbers. -- To view, visit http://gerrit.cloudera.org:8080/7033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I067f053fec941e3631610c5cc89a384f257ba906 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
