Henry Robinson has posted comments on this change. Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads ......................................................................
Patch Set 3: Code-Review+2 (2 comments) Carry +2 http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: PS2, Line 232: [this]() { this->ReportProfileThread(); })); > you rewrote the other cases to use a lambda here. i don't have a strong pre The other example used bind(..), which to my eye is less readable than a lambda. This one didn't cross my threshold for readability, but I fixed it now :) http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: PS2, Line 303: ad t(FragmentInstanceState::FINST_THR > same Done -- To view, visit http://gerrit.cloudera.org:8080/6951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
