Dan Hecht has posted comments on this change.

Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6951/2/be/src/runtime/fragment-instance-state.cc
File be/src/runtime/fragment-instance-state.cc:

PS2, Line 232: &FragmentInstanceState::ReportProfileThread, this
> The other example used bind(..), which to my eye is less readable than a la
I was talking about the non-bind one (kudu-scan-node). anyway, either way is 
fine.


-- 
To view, visit http://gerrit.cloudera.org:8080/6951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fabfcc923863e5f9db4bb8b016c08ff226c079f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: Yes

Reply via email to