Alex Behm has posted comments on this change.

Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after 
metadata loading
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7045/3/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

Line 901:         analysisCtx = new AnalysisContext(impaladCatalog_.get(), 
queryCtx,
Doesn't this destroy the analysisCtx.timeline_ and effectively hide how long 
the metadata loading took?

An alternative is to put add the atomic ref into the AnalysisCtx instead of a 
plain ref.


-- 
To view, visit http://gerrit.cloudera.org:8080/7045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I574d69fa75198499523dc291fbbd0d7e3d8d968f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-HasComments: Yes

Reply via email to