Alex Behm has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/7045/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: Line 237: impaladCatalog_.get().getAuthPolicy())); use catalog.getAuthPolicy() Line 610: List<String> tblNames = impaladCatalog_.get().getTableNames(dbName, matcher); I'm a little worried about the repercussions of operations seeing different versions of the catalog. For example, take a look at MetadataOp.getDbsMetadata() which accesses the catalog several times, and might see different versions. Some more comments along similar lines below. Maybe the new behavior is better than before, but if we do hit one of these edge cases, it might be very hard to debug. Thoughts? Line 890: AnalysisContext analysisCtx = new AnalysisContext(impaladCatalog_.get(), queryCtx, Are we guaranteed that this new catalog returns true for isReady()? Line 901: analysisCtx.setCatalog(impaladCatalog_.get()); Are we guaranteed that this new catalog returns true for isReady()? -- To view, visit http://gerrit.cloudera.org:8080/7045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574d69fa75198499523dc291fbbd0d7e3d8d968f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
