Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message ......................................................................
Patch Set 1: (1 comment) Thanks for the patch! Just one minor comment. http://gerrit.cloudera.org:8080/#/c/7051/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 1085: stringstream ss; : ss << "Invalid session id " << PrintId(session_id); : return Status(ss.str()); Prefer Substitute - less verbose and a bit easier to read (rest of the code base has been slowly moving that way over the past couple of years). return Substitute("Invalid session id: $0", PrintId(session_id)); -- To view, visit http://gerrit.cloudera.org:8080/7051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I921c9d13c1bbfb924416dc281649a74add904b66 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
