Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message ......................................................................
Patch Set 3: Code-Review+2 (1 comment) Looks good - please fix the long line, then I'll commit. Thanks! http://gerrit.cloudera.org:8080/#/c/7054/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: Line 435: return_val, Status(Substitute("Invalid session id: $0", PrintId(session_id))), SQLSTATE_GENERAL_ERROR); Nit: can you fix the long line? For readability, maybe split into two lines, one that creates the string, one that returns the status. -- To view, visit http://gerrit.cloudera.org:8080/7054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721951aaf2425da62e61d65150e462a83716b02e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-HasComments: Yes
