Alex Behm has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6550/4/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test: Line 68: ==== > I also thought about it, but eventually didn't do it because: Thanks for your consideration: * I think it's fine to add a simple query right here in this .test file. I agree it does not make sense to add a dedicated test file. * I think we should still add a test for the following reason. When we scan that file, the BE reads the file schema and resolves it against the table schema. There is no test that covers that the BE scanner reads and resolves a Parquet field annotated with ENUM correctly, so imo that coverage is missing. Even if it works today, someone may "fix" the Parquet scanner in the future and break this functionality. -- To view, visit http://gerrit.cloudera.org:8080/6550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jakub Kukul <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Jakub Kukul <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
