Alex Behm has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7004/2/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java: Line 115: * Updates the internal Catalog based on the given TCatalogUpdateReq. Update this comment to reflect the new strategy, might be good to explicitly mention what two-level hierarchy looks like exactly. http://gerrit.cloudera.org:8080/#/c/7004/2/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: Line 77: def restart_impalad(cls): restart_first_impalad? Line 102: sleep(10) 10s seems really high, can we get this to be more accurate, e.g., by using the configured statestore update frequency? Line 115: # Verify that we still have the right privileges the impalad was restarted. typo: after impala was restarted -- To view, visit http://gerrit.cloudera.org:8080/7004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7072e95b74952ce5a51ea1b6e2ae3e80fb0940e0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
