Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7004/3/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java File fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java: Line 120: * 3) Removes all dropped tables, views, and functions > 3) Removes all dropped catalog objects? Done Line 126: * Catalog updates are ordered by the object type with the dependent objects coming > This comment seems wrong, please rephrase. The objects are ordered by versi Done http://gerrit.cloudera.org:8080/#/c/7004/3/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: Line 94: statestored_args=("-statestore_heartbeat_frequency_ms=300 " > use double "-" for consistency Done Line 101: self.client.execute("create role test_role") > Make sure that whatever things we create in this test are cleaned up regard This is already handled in __test_cleanup. Look at line 64. -- To view, visit http://gerrit.cloudera.org:8080/7004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7072e95b74952ce5a51ea1b6e2ae3e80fb0940e0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
