Dan Hecht has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7008/4/be/src/exec/parquet-column-stats.inline.h File be/src/exec/parquet-column-stats.inline.h: PS4, Line 74: bytes_needed > 0 > Yes, this has to be > 0. I'm not sure a DCHECK prevents the compiler from i I believe the UB sanitizer is a runtime thing, not a compile time checker. So, this shouldn't be an issue for UBSAN since we can never get here with bytes_needed == 0. Let's make it a DCHECK then. -- To view, visit http://gerrit.cloudera.org:8080/7008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifef5c3de686318bff4eac7dfad6e1639ddadb8f2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
