Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7008/6/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 983: if (haystack == NULL) return NULL; This overly-restrictive DCHECK was exposed by the other parts of the change. -- To view, visit http://gerrit.cloudera.org:8080/7008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifef5c3de686318bff4eac7dfad6e1639ddadb8f2 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
