Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7064/3/be/src/service/client-request-state.h File be/src/service/client-request-state.h: Line 151: const bool user_has_profile_access() const { > single line if it fits Done Line 222: /// error. If base64_encoded is true, outputs the base64-encoded profile output, > This API is confusing to me. Why does base64_encoded influence the auth beh Removed. http://gerrit.cloudera.org:8080/#/c/7064/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 606: return request_state->GetRuntimeProfile(user, base64_encoded, output); > We not have many different GetRuntimeProfile*() and GetExecSummary() functi Added the CheckProfileAccess calls and removed the Get* functions. http://gerrit.cloudera.org:8080/#/c/7064/3/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 560: std::string limited_profile_str; > Remove? Done http://gerrit.cloudera.org:8080/#/c/7064/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 2535: public void registerPrivReq(PrivilegeRequest privReq) { > As discussed, I think this logic can be further simplified and made more ex Done -- To view, visit http://gerrit.cloudera.org:8080/7064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
