Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7064/1/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: Line 92: def test_access_runtime_profile(self): > Nice test! Done Line 135: execute_statement_req.statement = """create view if not exists tpch.customer_view as > Can we put this into a different db? Might be good to make sure this view i We need a db in which we have access to the tables for the positive test. Open to recommendations if you can think of a better option. Line 137: execute_statement_resp = self.hs2_client.ExecuteStatement(execute_statement_req) > also test that EXPLAIN works Done Line 145: # Repeat as a deleted user > delegated Done Line 281: """Runs statement 'stmt' and retrieves the runtime profile and exec summary. If > remove 'statement' Done -- To view, visit http://gerrit.cloudera.org:8080/7064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
