Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7168/2//COMMIT_MSG Commit Message: PS2, Line 7: NOT IN predicate shares the same selectivity as : IN predicate. > Change to what this commit fixes may be? Something like Fix the selectivity Done PS2, Line 18: predicae > typo Done http://gerrit.cloudera.org:8080/#/c/7168/2/tests/metadata/test_explain.py File tests/metadata/test_explain.py: Line 104: # IN predicate, cardinality should be 7300*(num of children/num of distinct values) > Not totally sure if there is a better place to add these tests, Alex any id Maybe I should just specify the expected value as a constant? Line 109: # NOT IN predicate, cardinality should be 7300*(1-(num of children/num of distinct values)) > nit: long line. Done -- To view, visit http://gerrit.cloudera.org:8080/7168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e6217257b5618cb63e13b32ba3347fa0483b63 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-HasComments: Yes
