Alex Behm has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates ......................................................................
Patch Set 3: (1 comment) Thanks for finding and fixing this. http://gerrit.cloudera.org:8080/#/c/7168/3/tests/metadata/test_explain.py File tests/metadata/test_explain.py: Line 105: result = self.execute_query("explain select * from %s.%s where id " Instead of this end-to-end test, please add a new FE unit test ExprSelectivityTest similar to ExprNdvTest. Relying on a full explain seems like overkill, and checking the scan cardinality is really an indirect test. -- To view, visit http://gerrit.cloudera.org:8080/7168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e6217257b5618cb63e13b32ba3347fa0483b63 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-HasComments: Yes
