Joe McDonnell has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/7079/1//COMMIT_MSG Commit Message: PS1, Line 12: query is finished > query has transitioned to a state in which it will no longer return any mor Done PS1, Line 17: and > an error Done PS1, Line 18: ended > cancelled Done Line 19: 3. The query reaches eos (or the DML completes) > Also: The query is cancelled by a client but not closed. (E.g. call HS2::Ca Done PS1, Line 22: complete > avoid this word, e.g. use the wording I suggested above Done Line 24: > call out the limitations, i.e. this doesn't mean all backends have complete Done Line 25: Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 > comment on testing? I assume we still need to do the cluster testing. Added a test and a description of the changes to the test. http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: Line 81: /// ImpalaServer::CancelInternal()/ClientRequestState::Cancel().) > augment comment Done -- To view, visit http://gerrit.cloudera.org:8080/7079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
