Joe McDonnell has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7079/3/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: PS3, Line 82: if (desc_tbl_ != nullptr) desc_tbl_->ReleaseResources(); This may need to be in ~QueryState(). I'm investigating how desc_tbl_ is used. So far, testing hasn't revealed any issue with having this here. -- To view, visit http://gerrit.cloudera.org:8080/7079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
