Lars Volker has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/7058/7/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: PS7, Line 474: Update null_count in page_stat_ page_stat_ doesn't exist. I think it would be easier to understand if you just inline ProcessNullValue here and update the comment accordingly. The extra level of indirection doesn't seem to help much with the readability. http://gerrit.cloudera.org:8080/#/c/7058/7/be/src/exec/parquet-column-stats.h File be/src/exec/parquet-column-stats.h: PS7, Line 159: value nit values PS7, Line 160: values to either value until... -- To view, visit http://gerrit.cloudera.org:8080/7058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c49a63af84c2234f0633be63206cb52eb7e8ebb Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-HasComments: Yes
