Dan Hecht has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/7058/8/be/src/exec/parquet-column-stats.h File be/src/exec/parquet-column-stats.h: PS8, Line 96: has_values is that dead now? if so, how about we delete it? Line 107: /// Stores whether the current object has been initialized with a set of values. it looks like has_value_ doesn't indicate whether null_count_ is valid or not, right? Let's clarify that, maybe say: ... with min and max values. -- To view, visit http://gerrit.cloudera.org:8080/7058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c49a63af84c2234f0633be63206cb52eb7e8ebb Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-HasComments: Yes
