Alex Behm has posted comments on this change. Change subject: IMPALA-4418: Extra blank lines in query result ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7055/2/shell/impala_shell.py File shell/impala_shell.py: Line 919: if len(rows) == 0: Comment on why we are doing this http://gerrit.cloudera.org:8080/#/c/7055/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: Line 294: # DROP and USE are exception cases that client does not fetch Prefix with IMPALA-4418 Line 297: run_impala_shell_interactive("drop database if exists d1;") Why not use a test similar to what was reported in the JIRA, i.e. issue a use? According to the JIRA the use should do a zero row fetch. Better to avoid adding dummy dbs and tables, especially with short names. Those might conflict with local stuff a dev has. -- To view, visit http://gerrit.cloudera.org:8080/7055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
