Vincent Tran has posted comments on this change.

Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7055/3//COMMIT_MSG
Commit Message:

Line 11: that returns 0 row.
> This change avoids printing blank lines when the Impala shell fetches 0 row
Done


http://gerrit.cloudera.org:8080/#/c/7055/3/shell/impala_shell.py
File shell/impala_shell.py:

Line 922:           # IMPALA-4418: Breaking out of the loop to prevent an empty 
newline printing
> Break out of the loop to prevent printing an unnecessary empty line.
Done


http://gerrit.cloudera.org:8080/#/c/7055/3/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

Line 293:     # IMPALA-4418
> We use this format
Done


Line 294:     # DROP and USE are exception cases that client does not fetch.
> DROP and USE are generally exceptional statements where the client does not
Done


Line 296:     # CREATE [DATABASE|TABLE] should trigger a 0 row fetch
> Remove this part about CREATE in favor of the more general formulation abov
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Vincent Tran <[email protected]>
Gerrit-HasComments: Yes

Reply via email to