Tim Armstrong has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7180/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 510: OutputUnmatchedBuild(out_batch); > I think we should check the status returned by this function for any error Nice catch. We definitely shouldn't drop this status. I added WARN_UNUSED_RESULT to all of the relevant functions in the hash join node and fixed this and a few other places. -- To view, visit http://gerrit.cloudera.org:8080/7180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I075388d348499c5692d044ac1bc38dd8dd0b10c7 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
