Dan Hecht has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM ......................................................................
Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7180/6/be/src/exec/partitioned-hash-join-node-ir.cc File be/src/exec/partitioned-hash-join-node-ir.cc: Line 238: || JoinOp == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN) { the old formatting seemed more readable, but up to you. http://gerrit.cloudera.org:8080/#/c/7180/6/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 609: if (!output_build_partitions_.empty()) continue; the control flow in this loop is still pretty hard to read, but not for this change. -- To view, visit http://gerrit.cloudera.org:8080/7180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I075388d348499c5692d044ac1bc38dd8dd0b10c7 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
