Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: Line 226: VLOG_ROW << "uncompressed size: " << size << ", compressed size: " << compressed_size; nit: Not your change. It's a no-op, but I think we should call compressor.Close() to be consistent. -- To view, visit http://gerrit.cloudera.org:8080/7226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
