Michael Ho has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: PS1, Line 100: DCHECK(input_batch.compression_type == THdfsCompression::LZ4) DCHECK_EQ(); Line 226: VLOG_ROW << "uncompressed size: " << size << ", compressed size: " << compressed_size; > nit: Not your change. Not your change either but it's unfortunate that we don't call Close() if ProcessBlock() fails above. http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/util/compress.h File be/src/util/compress.h: Line 47: virtual Status Init(); WARN_UNUSED_RESULT http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/util/decompress.h File be/src/util/decompress.h: PS1, Line 38: ; WARN_UNUSED_RESULT. Same below. Line 41: const uint8_t* input, int64_t* output_length, uint8_t** output); WARN_UNUSED_RESULT. Same below. Line 44: bool* stream_end); WARN_UNUSED_RESULT. Same below. -- To view, visit http://gerrit.cloudera.org:8080/7226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
