Tim Armstrong has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts ......................................................................
Patch Set 1: (2 comments) The overall approach makes sense to me. Happy to talk about the computeResourceProfile() stuff in the planner if that would be helpful. http://gerrit.cloudera.org:8080/#/c/7267/1/be/src/exec/partial-sort-node.cc File be/src/exec/partial-sort-node.cc: Line 104: RETURN_IF_ERROR(sorter_->Open()); I think you'll want to wait until the next call into GetNext() to re-open the sorter. At this point row_batch may still be holding onto memory that Open() will want to use. Line 115: do { I think it would make sense to open the sorter here (if it's not already open). -- To view, visit http://gerrit.cloudera.org:8080/7267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
