Matthew Jacobs has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts ......................................................................
Patch Set 2: (2 comments) did a quick pass again, I think it looks pretty good. Anything major needed before considering this a non-draft review? I suppose just testing? http://gerrit.cloudera.org:8080/#/c/7267/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: PS2, Line 296: root = SortNode.createTopNSortNode(ctx_.getNextNodeId(), root, stmt.getSortInfo(), stmt.getOffset()); long line http://gerrit.cloudera.org:8080/#/c/7267/2/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: PS2, Line 93: Maybe make this one a static factory for consistency. I like them- very readable -- To view, visit http://gerrit.cloudera.org:8080/7267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
