Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7275
Change subject: IMPALA-5567: race in fragment instance teardown ...................................................................... IMPALA-5567: race in fragment instance teardown The bug is that PlanRootSink::GetNext() calls RuntimeState::CheckQueryState() was called concurrently with RuntimeState::ReleaseResources() and got a reference The other callsites of CheckQueryState() are safe because they are in two categories: * ExecNodes or DataSink methods executed by fragment instance execution threads, which must terminate before the runtime state resources are released. * In FeSupport where ReleaseResources() called after CheckQueryState() There is no need to asynchronously check for memory limit exceeded in PlanRootSink::GetNext() since that method does not allocate tracked memory that could push the query over the memory limit. Change-Id: If567e734042b5f2b82323368dd536dbf3bdf4744 --- M be/src/exec/plan-root-sink.cc M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/7275/1 -- To view, visit http://gerrit.cloudera.org:8080/7275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If567e734042b5f2b82323368dd536dbf3bdf4744 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]>
