Michael Ho has posted comments on this change. Change subject: IMPALA-5567: race in fragment instance teardown ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7275/1/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: Line 102: ScalarExprEvaluator::FreeLocalAllocations(output_expr_evals_); Not your change but should we check for query status here too ? I can imagine expression evaluations above can lead to MemLimitExceeded. Feel free to do it later though. PS1, Line 150: DCHECK( DCHECK_GE() -- To view, visit http://gerrit.cloudera.org:8080/7275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If567e734042b5f2b82323368dd536dbf3bdf4744 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
