Michael Ho has posted comments on this change.

Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
......................................................................


Patch Set 19:

GVD failed for two reasons:
1. a bunch of clang-tidy warnings.
2. statestored and catalogd failed to start:

ERROR: something wrong with flag 'logtostderr' in file 'src/logging.cc'.  One 
possibility: file 'src/logging.cc' is being linked both statically and 
dynamically into this executable.

May be we should really clean up those files in kudu/util which overlap with 
existing Impala code (e.g. logging and minidump).

-- 
To view, visit http://gerrit.cloudera.org:8080/5715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5
Gerrit-PatchSet: 19
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to