Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ......................................................................
Patch Set 20: PS20 got further than before (i.e. impalad binaries can start up with --build_shared_libraries) and passed almost all tests. There's another shared lib linking bug where protobuf would get linked into the binaries more than once, because it was statically linked into different .so libraries. This does not work well, because libprotobuf makes use of global d'tors that can't be run more than once. So all processes were crashing on exit (hence the unit-test failures etc). PS21 includes a fix for this issue: libprotobuf is linked according to BUILD_SHARED_LIBS, rather than always being statically linked. -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 Gerrit-PatchSet: 20 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
