Michael Ho has posted comments on this change. Change subject: IMPALA-5558/IMPALA-5576: Reopen stale client connection ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/7284/8/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: PS8, Line 362: true; > i don't understand that. connect_success can be true if the previous client In theory, we can try creating connection for 3 times and still fails. In which case, is it supposed to be considered "not attempted" as the RPC was never made ? Or may be it's simpler to just consider it attempted. http://gerrit.cloudera.org:8080/#/c/7284/8/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: PS8, Line 138: > ReportExecStatus RPC messages Done http://gerrit.cloudera.org:8080/#/c/7284/8/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: Line 225: DCHECK_EQ(res.status.status_code, TErrorCode::OK); > it'd be good to explain that retry is always safe for this rpc because the Done -- To view, visit http://gerrit.cloudera.org:8080/7284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d722c8ad3bf0e78e89887b6cb286c69ca61b8f5 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
