Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5558/IMPALA-5576: Reopen stale client connection ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/7284/8/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS8, Line 198: TTransportException::END_OF_FILE && : strstr(e.what(), "No more data to read. > It comes from the following line in the thrift library: Can you put this in a comment as well? http://gerrit.cloudera.org:8080/#/c/7284/8/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: PS8, Line 362: connect_success > In theory, we can try creating connection for 3 times and still fails. In w I was also wondering if this return value isn't very useful. What if we instead return when the operation was definitely completed successfully, i.e. the rpc is sent w/ rpc_status OK OR this is a no-op (e.g. no exec rpc sent/completed successfully already). Then we can update the logging statement in coordinator.cc that uses this. I don't see anywhere that we'd get these error status_ logged though. Perhaps if there were any errors, then coordinator.cc should be logging the output of Coordinator::GetErrorLog() which has the merged backend_state_ statuses. -- To view, visit http://gerrit.cloudera.org:8080/7284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d722c8ad3bf0e78e89887b6cb286c69ca61b8f5 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
