Michael Ho has posted comments on this change. Change subject: IMPALA-5558/IMPALA-5576: Reopen stale client connection ......................................................................
Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/7284/10//COMMIT_MSG Commit Message: Line 54: > can you mention the test coverage that has been completed? Done http://gerrit.cloudera.org:8080/#/c/7284/10/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: PS10, Line 198: String take > Strings taken? Done PS10, Line 198: TSocker > typo Done http://gerrit.cloudera.org:8080/#/c/7284/10/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: PS10, Line 248: if (instance_stats->done_) continue; > It would be good to mention this fix in the commit message too. Done PS10, Line 353: SleepForMs(100); > Just wondering if it's a good idea to have the coordinator thread go to sle Oops.. I missed the lock up there. Definitely we shouldn't sleep in this case. Sorry for missing that and thanks for pointing that out. PS10, Line 356: status_.MergeStatus(client_status); > Isn't this redundant if you're adding its message as a detail below in L361 MergeStatus() is needed in case status_.msg_ is NULL. I agree that it's redundant to call AddDetails() below though. PS10, Line 365: status_.MergeStatus(rpc_status); > Same here Fixed. -- To view, visit http://gerrit.cloudera.org:8080/7284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d722c8ad3bf0e78e89887b6cb286c69ca61b8f5 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
