Dan Hecht has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple ......................................................................
Patch Set 2: (2 comments) nice http://gerrit.cloudera.org:8080/#/c/7303/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: PS2, Line 72: 128 bytes update http://gerrit.cloudera.org:8080/#/c/7303/2/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: PS2, Line 571: StringValue sv what's the point of this StringValue now? This seems confusing and round about. (It's also weird that dst type is StringValue*, but that's a pre-existing weirdness). Seems more straightforward to just do: char* dst_char = reinterpret_cast<char*>(dst); and use dst_char wherever sv.ptr is used. -- To view, visit http://gerrit.cloudera.org:8080/7303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0b823ccff6b0c37f5267c548d096c29b8caac3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
