Dan Hecht has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7303/3/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: PS3, Line 523: dst I think this would be clearer if we say "the slot 'dst'". or rename 'dst' to 'slot' -- To view, visit http://gerrit.cloudera.org:8080/7303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0b823ccff6b0c37f5267c548d096c29b8caac3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
